Add Memoized and fix AlonzoTxAuxData
#3165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/memoized
branch
from
cbb7cf4 to
971d73c
Compare
lehins
force-pushed
the
lehins/memoized
branch
2 times, most recently
from
06a5e61 to
c75b2cd
Compare
lehins
commented
Nov 23, 2022
lehins
force-pushed
the
lehins/memoized
branch
5 times, most recently
from
b355efb to
c2233d4
Compare
lehins
force-pushed
the
lehins/memoized
branch
from
c2233d4 to
b888dd8
Compare
JaredCorduan
approved these changes
Nov 29, 2022
There was a problem hiding this comment.
This looks awesome, thanks @lehins ! I only had trivial comments.
This class allows us to abstract away common parts from MemoBytes usage and reduce duplication. Besides improving safety it also provides us with an easy way to operate on the underlying raw type.
lehins
force-pushed
the
lehins/memoized
branch
from
c0db9ca to
1c8ff01
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major additions and changes in this PR:
Eqinstance forMemoBytesalso compares the raw Haskell value, not just binary serialization.Memoizedtype class that abstracts away the common pattern of operating on a type that is based onMemoBytesAlonzoTxAuxDatadoes not roundtrip serialization #3166AlonzoTxAuxDataas suggested in this comment Implementation ofAlonzoTxAuxDatadoes not roundtrip serialization #3166 (comment)Fixes #3166