-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GADT for TransactionScriptFailure and PlutusDebug #3167
GADT for TransactionScriptFailure and PlutusDebug #3167
Conversation
af8429b
to
3ea4e01
Compare
3ea4e01
to
5f0e101
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few things need adjusting, but overall this is great stuff!!!
After this PR will probably be able to adopt this approach in other places as well, specific type that comes to mind is CostParams
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really great @aniketd , thanks for improving the type safety of our code!
NOTE: My current standing on this PR is that I'm uncertain only about the CBOR instances that have changed, and would like for someone to take a closer look at them. Besides those, the rest of the changes seem to be okay, and the failing tests are likely unrelated. The unexpected failure caused in an earlier CI run is also reproducible otherwise, so investigating that could be considered separately from this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it does look good, but the changes to CBOR encoding/decoding got broken.
It would be nice if you could add some roundtrip tests for the PlutusDebug
serialization. At least it would give us some confidence that it is ok. You'll need to add a few Arbitrary instances here: Test.Cardano.Ledger.Alonzo.Serialisation.Generators
for it to work.
I'm going to clean up the commit history in preparation for the merge. |
fb997ca
to
090ee6d
Compare
I have cleaned up the commit history and rebased on |
090ee6d
to
cd2e285
Compare
cd2e285
to
da7e3bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome!
da7e3bb
to
f050446
Compare
f050446
to
d56253c
Compare
NOTE:
Plutus.*
imports in a standard form of eitherPV1
(PlutusLedgerApi.V1
),PV2
(PlutusLedgerApi.V2
) orPCD
(PlutusCore.Data
)PlutusDebug
a GADT.TODO: