-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a TxBody to Conway #3176
Add a TxBody to Conway #3176
Conversation
@Soupstraw FYI, checkout recent changes to TxBodyRaw and TxBody field naming. We want to keep it consistent going forward. and |
ea1fffc
to
18e59a7
Compare
2c92497
to
52017ce
Compare
There's a few |
Oh I thought I handled all of them. Let me check |
52017ce
to
c611577
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is some more feedback, besides what @teodanciu already pointed about a bunch if undefined
.
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Examples/STSTestUtils.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Generic/AggPropTests.hs
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Generic/MockChain.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Generic/PrettyCore.hs
Outdated
Show resolved
Hide resolved
42ffa04
to
237d9b6
Compare
eras/conway/impl/src/Cardano/Ledger/Conway/Delegation/Certificates.hs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is awesome work @Soupstraw , thank you! I made a few small comments.
8365391
to
5e82cbc
Compare
772deb8
to
5311a25
Compare
Co-authored-by: Jared Corduan <jared.corduan@iohk.io>
5311a25
to
efa04f1
Compare
This PR adds the
ConwayTxBody
data type. It deprecates protocol parameter updates and mir certificates, and adds sequences of governance actions and votes to the transaction body.I added new data types
Vote
andGovernanceActionInfo
, which store information about votes and governance actions respectively.The currently supported governance actions are:
I also implemented ToCBOR and FromCBOR instances for all the new data types and created a new CDDL file for Conway era.
Some of the Conway tests were disabled for now until we get the rules sorted out. I added TODO comments in those places.
resolves #3145
resolves #3154