Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a TxBody to Conway #3176

Merged
merged 14 commits into from
Dec 13, 2022
Merged

Add a TxBody to Conway #3176

merged 14 commits into from
Dec 13, 2022

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Dec 1, 2022

This PR adds the ConwayTxBody data type. It deprecates protocol parameter updates and mir certificates, and adds sequences of governance actions and votes to the transaction body.

I added new data types Vote and GovernanceActionInfo, which store information about votes and governance actions respectively.

The currently supported governance actions are:

  • parameter change
  • hard fork initiation
  • treasury withdrawals

I also implemented ToCBOR and FromCBOR instances for all the new data types and created a new CDDL file for Conway era.

Some of the Conway tests were disabled for now until we get the rules sorted out. I added TODO comments in those places.

resolves #3145
resolves #3154

@lehins
Copy link
Collaborator

lehins commented Dec 1, 2022

@Soupstraw Soupstraw force-pushed the jj/conway-txbody branch 3 times, most recently from ea1fffc to 18e59a7 Compare December 2, 2022 11:48
@Soupstraw Soupstraw marked this pull request as ready for review December 2, 2022 11:54
@Soupstraw Soupstraw force-pushed the jj/conway-txbody branch 2 times, most recently from 2c92497 to 52017ce Compare December 2, 2022 13:04
@teodanciu
Copy link
Contributor

There's a few undefined in the code, did you want to merge them like this @Soupstraw ?

@Soupstraw
Copy link
Contributor Author

Oh I thought I handled all of them. Let me check

@Soupstraw Soupstraw marked this pull request as draft December 2, 2022 14:05
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is some more feedback, besides what @teodanciu already pointed about a bunch if undefined.

eras/conway/impl/src/Cardano/Ledger/Conway/Core.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Core.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Core.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Core.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Rules.hs Outdated Show resolved Hide resolved
@Soupstraw Soupstraw force-pushed the jj/conway-txbody branch 15 times, most recently from 42ffa04 to 237d9b6 Compare December 6, 2022 16:44
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome work @Soupstraw , thank you! I made a few small comments.

@Soupstraw Soupstraw force-pushed the jj/conway-txbody branch 8 times, most recently from 772deb8 to 5311a25 Compare December 13, 2022 15:44
Co-authored-by: Jared Corduan <jared.corduan@iohk.io>
@Soupstraw Soupstraw merged commit dc3dffc into master Dec 13, 2022
@iohk-bors iohk-bors bot deleted the jj/conway-txbody branch December 13, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

conway CDDL spec conway transaction body
4 participants