-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrapped the public facing API of cardano-ledger-api #3182
Bootstrapped the public facing API of cardano-ledger-api #3182
Conversation
151797e
to
f83b96b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this. One important comment, otherwise looks good.
f83b96b
to
65946a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @koslambrou , this looks wonderful!
da62ce2
to
9f43f45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Just a few minor comments.
Thank you for your effort!
* Created the `Cardano.Ledger.Api` module which should export anything the end-user will need in order to build and inspect transactions. * Added some new modules in `cardano-ledger-api`, but it is still not complete. * Completing some missing exports in lower modules * Bootstrapped very simple documentation on how to build and inspect transactions
9f43f45
to
5038486
Compare
Thanks for reviewing @lehins :) More to come. |
Summary
Created the
Cardano.Ledger.Api
module which exports anything the end-user will need in order to build and inspect transactions.Completing some missing exports in lower modules
Bootstrapped very simple documentation on how to build and inspect transactions
Notes
After trying out
cardano-ledger-api
, this is my simple attempt to bootstrap some documentation on how to use the API from an external user's perspective.I made some opinionated changes, so that I can get something started.