Create core test sublib #3184
Merged
Create core test sublib #3184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/create-core-test-sublib
branch
from
2b6a275
to
99a5c4b
Compare
lehins
force-pushed
the
lehins/create-core-test-sublib
branch
from
fbcdbc9
to
394a62d
Compare
lehins
force-pushed
the
lehins/create-core-test-sublib
branch
from
394a62d
to
f5c93e9
Compare
TimSheard
approved these changes
Dec 5, 2022
libs/cardano-ledger-binary/src/Cardano/Ledger/Binary/Decoding/FromCBOR.hs
Outdated
Show resolved
Hide resolved
eras/shelley/test-suite/src/Test/Cardano/Ledger/Shelley/Serialisation/EraIndepGenerators.hs
Show resolved
Hide resolved
eras/shelley/test-suite/src/Test/Cardano/Ledger/Shelley/Serialisation/EraIndepGenerators.hs
Show resolved
Hide resolved
teodanciu
reviewed
Dec 5, 2022
eras/shelley/test-suite/src/Test/Cardano/Ledger/Shelley/Serialisation/EraIndepGenerators.hs
Show resolved
Hide resolved
teodanciu
reviewed
Dec 5, 2022
eras/shelley/test-suite/src/Test/Cardano/Ledger/Shelley/Serialisation/EraIndepGenerators.hs
Show resolved
Hide resolved
teodanciu
reviewed
Dec 5, 2022
lehins
force-pushed
the
lehins/create-core-test-sublib
branch
from
f5c93e9
to
a864e06
Compare
teodanciu
reviewed
Dec 5, 2022
teodanciu
reviewed
Dec 5, 2022
libs/cardano-ledger-binary/test/Test/Cardano/Ledger/Binary/Vintage/Serialization.hs
Show resolved
Hide resolved
lehins
force-pushed
the
lehins/create-core-test-sublib
branch
from
a864e06
to
fbc11c4
Compare
Remove redundant Hedgehog generators in favor of Arbitrary instances
lehins
force-pushed
the
lehins/create-core-test-sublib
branch
from
fbc11c4
to
ab5026e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up, organizes Arbitrary instances for all of the
cardano-ledger-coretypes in the newly createdcardano-ledger-core:testlib. Also it removes some of the duplicate hedgehog generators, that are now fully replaced byQuickCheckinstances.It is important to note that this is just the beginning of the test suite cleanup, therefore more PRs like this one are expected to be coming in the future.