Fix transVITime to use open upper bound. #3200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koslambrou
reviewed
Dec 6, 2022
JaredCorduan
approved these changes
Dec 6, 2022
|
@ak3n - let's add something to the CHANGLOG.md about this great fix. You can add it to |
JaredCorduan
reviewed
Dec 6, 2022
Co-authored-by: Jared Corduan <jaredcorduan@gmail.com>
|
@JaredCorduan added the line to changelog. Have no idea what's wrong with the ci... |
thank you! the failure in cicero on the darwin machine has nothing to do with your changes, it's currently just a very flaky job. |
|
@JaredCorduan thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3043.
I have tried to use the Hardforks technique mentioned here #3043 (comment).