optimize TICKF #3209
Merged
optimize TICKF #3209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaredCorduan
force-pushed
the
jc/memoize-pool-distr
branch
2 times, most recently
from
ec56a75 to
3f93e3e
Compare
lehins
reviewed
Dec 14, 2022
lehins
reviewed
Dec 14, 2022
aniketd
requested changes
Dec 15, 2022
eras/shelley/test-suite/test/Test/Cardano/Ledger/Shelley/RulesTests.hs
Outdated
Show resolved
Hide resolved
lehins
approved these changes
Dec 15, 2022
eras/shelley/test-suite/test/Test/Cardano/Ledger/Shelley/RulesTests.hs
Outdated
Show resolved
Hide resolved
eras/shelley/test-suite/test/Test/Cardano/Ledger/Shelley/RulesTests.hs
Outdated
Show resolved
Hide resolved
eras/shelley/test-suite/test/Test/Cardano/Ledger/Shelley/RulesTests.hs
Outdated
Show resolved
Hide resolved
JaredCorduan
commented
Dec 15, 2022
eras/shelley/test-suite/test/Test/Cardano/Ledger/Shelley/RulesTests.hs
Outdated
Show resolved
Hide resolved
JaredCorduan
force-pushed
the
jc/memoize-pool-distr
branch
from
7d4660d to
7e6c081
Compare
added 4 commits
December 15, 2022 19:12
Calculating the stake pool distribution in the NEWEPOCH rule is problematic due to its role in the consensus layer. When a node checks to see if it is the leader for a slot crossing the epoch boundary, the node re-computes the distribution every second, and the calculation takes over a second. As a stop gap measure, we memoize the computation by creating a thunk for it at the moment when all the data is available, which happens to be an entire epoch before it is needed. In particular, we create the thunk inside the `SnapShots` record in the SNAP rule.
TICKF now only includes the logic needed to compute the same LedgerView as TICK.
JaredCorduan
force-pushed
the
jc/memoize-pool-distr
branch
from
7e6c081 to
69bbb7a
Compare
This was referenced Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR optimizes the
TICKFtransition, particularly for the problematically slow computations on the epoch boundary. See the ADR in this PR for more context. See also #3034.This PR consists of four commits: one for each of the two optimizations mentioned in the ADR, one for the ADR, and one to fix a broken link in the PR template.
I did not update the changelog since all the changes are invisible outside of this code base.
replaces #3140 and #3141
Checklist
scripts/ormolise.sh