Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move KeyPair to test lib #3210

Merged
merged 4 commits into from
Dec 21, 2022
Merged

Move KeyPair to test lib #3210

merged 4 commits into from
Dec 21, 2022

Conversation

teodanciu
Copy link
Contributor

@teodanciu teodanciu commented Dec 13, 2022 •
edited
Loading

Description

Closes #3186

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with ormolu (which can be run with scripts/ormolise.sh
  • Self-reviewed the diff

@teodanciu teodanciu marked this pull request as ready for review December 13, 2022 16:45
JaredCorduan
JaredCorduan reviewed Dec 13, 2022
View reviewed changes
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very happy to be moving this to the tests, thank you! I had just one comment about deprecating KeyPair from the API.

@teodanciu teodanciu force-pushed the td/move-keypair-to-test branch 2 times, most recently from 0c2af7e to 9c929ba Compare December 14, 2022 10:51
@teodanciu teodanciu force-pushed the td/move-keypair-to-test branch 2 times, most recently from 3c8d2bf to 8710bba Compare December 14, 2022 16:04
@teodanciu teodanciu force-pushed the td/move-keypair-to-test branch from 8710bba to 77c72f4 Compare December 15, 2022 14:16
JaredCorduan
JaredCorduan approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thank you!

lehins
lehins approved these changes Dec 15, 2022
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Awesome. I don't think anyone outside our tests uses the KeyPair type, but just in case deprecating is not a bad idea.

@teodanciu teodanciu force-pushed the td/move-keypair-to-test branch 2 times, most recently from 40c5271 to 9cd9ef2 Compare December 20, 2022 15:32
@teodanciu teodanciu force-pushed the td/move-keypair-to-test branch from 9cd9ef2 to 1dad922 Compare December 20, 2022 15:46
@teodanciu teodanciu merged commit 74fc976 into master Dec 21, 2022
@iohk-bors iohk-bors bot deleted the td/move-keypair-to-test branch December 21, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredCorduan JaredCorduan JaredCorduan approved these changes

@lehins lehins lehins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KeyPair should be moved to tests
3 participants
@teodanciu @JaredCorduan @lehins