Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust deposits event #3212

Merged
merged 1 commit into from Dec 27, 2022
Merged

Conversation

kderme
Copy link
Contributor

@kderme kderme commented Dec 13, 2022

Description

The tx hash is used to associate the event with the tx since the events within a block can appear out of order. The adjustment from deposits to deposits change is useful for db-sync.

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with ormolu (which can be run with scripts/ormolise.sh
  • Self-reviewed the diff

Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. I think db-sync is the only consumer of the ledger events at the moment, but I think in the future we'll probably want to mention changes to them in the changelog.

@kderme
Copy link
Contributor Author

kderme commented Dec 16, 2022

looks good. I think db-sync is the only consumer of the ledger events at the moment, but I think in the future we'll probably want to mention changes to them in the changelog.

A changelog entry is now added

The tx hash is used to associate the event with the tx since the events within
a block can appear out of order. The adjustment from deposits to deposits
change is useful for db-sync.
@JaredCorduan JaredCorduan merged commit e179695 into IntersectMBO:master Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants