Fold the keyDeposit into the UMap #3217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimSheard
force-pushed
the
ts-keydeposit-intoUMap
branch
from
8abf077 to
6378a36
Compare
TimSheard
changed the title
TimSheard
force-pushed
the
ts-keydeposit-intoUMap
branch
2 times, most recently
from
c916bad to
c80a94a
Compare
JaredCorduan
approved these changes
Dec 27, 2022
TimSheard
force-pushed
the
ts-keydeposit-intoUMap
branch
2 times, most recently
from
e39b82e to
625f1ae
Compare
lehins
approved these changes
Jan 4, 2023
eras/shelley/impl/src/Cardano/Ledger/Shelley/LedgerState/IncrementalStake.hs
Outdated
Show resolved
Hide resolved
eras/shelley/impl/src/Cardano/Ledger/Shelley/LedgerState/IncrementalStake.hs
Outdated
Show resolved
Hide resolved
eras/shelley/impl/src/Cardano/Ledger/Shelley/LedgerState/RefundsAndDeposits.hs
Outdated
Show resolved
Hide resolved
eras/shelley/test-suite/src/Test/Cardano/Ledger/Shelley/Generator/Trace/Chain.hs
Outdated
Show resolved
Hide resolved
eras/shelley/test-suite/test/Test/Cardano/Ledger/Shelley/Examples/Combinators.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-binary/testlib/Test/Cardano/Ledger/Binary/TreeDiff.hs
Outdated
Show resolved
Hide resolved
TimSheard
force-pushed
the
ts-keydeposit-intoUMap
branch
from
7233960 to
6c180a7
Compare
Data.UMap(UMap). It will store a Word64 instead of a Coin, and its interface uses (CompactForm Coin) which is a newtype around a Word64. Defined the dsUnified field of DState to be this new UMap. Updated all uses to this new interface. Changed UMapCompact to roll key deposits into the Unified map. Removed dsDeposits in DState, fixed code to use new UMap version of deposit map. Changed DState CBOR, golden encoding, added changelog entries
lehins
force-pushed
the
ts-keydeposit-intoUMap
branch
from
6c180a7 to
039c042
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We change the Rewards View of the UMap so that it map to a Reward-Deposit-Pair, so the single view stores both
the reward amount (a (CompactForm Coin)) for a staking credential, and a deposit amount (a (CompactForm Coin))
for the same credential.
Because we have UMap version of deposits, we no longer need the dsDeposits field for DState. It was removed.
The purpose of this PR is to save space, as there are millions of staking credentials, Since we are using compact coins, this should take about 1 extra Word64 per credential for deposits, and 2 less Word64 per credential for rewards (which used to be Coin). So this actually uses less memory.
A few things in the tools Cardano.Ledger.State.Query will need to fixed in a follow on PR