Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Shelley/BabbageTxOut to a more general TxOut #3222

Merged
merged 4 commits into from
Dec 27, 2022

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Dec 27, 2022

Description

By switching to more general type family TxOut from a concrete one, we can reduce number of constraints needed in many places, thus simplifying the code a bit. There are no semantic changes in this PR, just cleanup.

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with ormolu (which can be run with scripts/ormolise.sh
  • Self-reviewed the diff

@lehins lehins force-pushed the lehins/switch-BabbageTxOut-to-TxOut-in-BabbageTxBody branch from 7bce8d1 to 07131e7 Compare December 27, 2022 17:45
@lehins lehins force-pushed the lehins/switch-BabbageTxOut-to-TxOut-in-BabbageTxBody branch from 07131e7 to eac3652 Compare December 27, 2022 17:52
@lehins lehins requested a review from JaredCorduan December 27, 2022 17:53
@lehins lehins changed the title Switch from BabbageTxOut to a more general TxOut in BabbageTxBody Switch from Shelley/BabbageTxOut to a more general TxOut Dec 27, 2022
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic clean up, thank you!

@lehins lehins merged commit f9d3b45 into master Dec 27, 2022
@iohk-bors iohk-bors bot deleted the lehins/switch-BabbageTxOut-to-TxOut-in-BabbageTxBody branch December 27, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants