Switch ShelleyGenesis parameterization on era in favor of crypto #3224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
ShelleyGenesis era
->ShelleyGenesis c
, which means thatPParams
in the type are restricted toPParams (ShelleyEra c)
, instead ofShelleyParams era
. This is necessary, because we do in fact want the pparams from the Shelley era, instead of any other era that uses the same type.TranslateEra
instance forShelleygenesis
, since it makes no sense to upgrade a type that is not parameterized by an era. It was wrong to add that instance to begin with.CanStartFromGenesis
class, by abstracting the PParam abstract logic withfromShelleyPParams
, which is the only part that is different between eras.ConwayGenesis
, by addingAlonzoGenesis
, which is needed for the ability to upgrade PParams all the way from ShelleyEra.Cardano.Ledger.Babbage.Genesis
module, since now it is completely empty, because duplicated logic for upgrading PParams was removed.Checklist
scripts/ormolise.sh