Add CDDL proptests for Conway #3226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniketd
force-pushed
the
aniketd/conway-cddl-proptests
branch
3 times, most recently
from
b7724f6 to
2766de5
Compare
JaredCorduan
reviewed
Jan 3, 2023
JaredCorduan
approved these changes
Jan 3, 2023
aniketd
force-pushed
the
aniketd/conway-cddl-proptests
branch
from
ae73a27 to
2766de5
Compare
Soupstraw
reviewed
Jan 4, 2023
Soupstraw
reviewed
Jan 4, 2023
aniketd
force-pushed
the
aniketd/conway-cddl-proptests
branch
2 times, most recently
from
f7dfe59 to
8ced4cf
Compare
lehins
requested changes
Jan 4, 2023
There was a problem hiding this comment.
It is very unusual for Cardano.Ledger.Binary.Coders interface to need a change, so if you feel like you need to do that, more than likely you are doing something wrong.
Other than that it looks good.
FYI you could also use the new decodeBoundedEnum and encodeEnum for To/FromCBOR instances for Language
libs/cardano-ledger-binary/src/Cardano/Ledger/Binary/Decoding/Coders.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-binary/src/Cardano/Ledger/Binary/Decoding/Coders.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-binary/src/Cardano/Ledger/Binary/Decoding/Coders.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-binary/src/Cardano/Ledger/Binary/Encoding/Coders.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-binary/src/Cardano/Ledger/Binary/Encoding/Coders.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-binary/src/Cardano/Ledger/Binary/Encoding/Coders.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-binary/src/Cardano/Ledger/Binary/Encoding/Coders.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-binary/src/Cardano/Ledger/Binary/Encoding/Encoder.hs
Outdated
Show resolved
Hide resolved
aniketd
force-pushed
the
aniketd/conway-cddl-proptests
branch
from
8ced4cf to
415ba10
Compare
aniketd
force-pushed
the
aniketd/conway-cddl-proptests
branch
from
415ba10 to
dea517c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #3155
Checklist
scripts/ormolise.sh