Use listLen for RmdrPtr codec #3269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniketd
force-pushed
the
aniketd/redeemers-codec-comments
branch
from
0268d87 to
1271275
Compare
JaredCorduan
approved these changes
Jan 30, 2023
There was a problem hiding this comment.
LGTM! (I tried to think if there was something more clever we could do besides using that dummy value, but didn't come up with anything. maybe @lehins has an idea?) thanks!
lehins
approved these changes
Jan 30, 2023
aniketd
force-pushed
the
aniketd/redeemers-codec-comments
branch
from
1271275 to
641c0d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a followup from #3263, taking only the general enhancements made in that PR.
Checklist
fourmolu(which can be run withscripts/fourmolize.sh