Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containers internal tests #3270

Merged
merged 12 commits into from
Jan 25, 2023
Merged

Containers internal tests #3270

merged 12 commits into from
Jan 25, 2023

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Jan 23, 2023

Description

Some property tests that check custom functions that use internals from containers package. Nothing bad was discovered

Also adds asserts on two usages of dangerous mergeWithKey functions.

Fixes show instance for AsetName

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu (which can be run with scripts/fourmolize.sh
  • Self-reviewed the diff

@lehins lehins force-pushed the lehins/containers-internal-tests branch from 9267c41 to 79c7a7d Compare January 23, 2023 22:20
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it's always great to have more tests!

@lehins lehins force-pushed the lehins/containers-internal-tests branch from 897648f to 230c250 Compare January 24, 2023 17:34
@lehins lehins force-pushed the lehins/containers-internal-tests branch from 230c250 to 122fee1 Compare January 25, 2023 09:31
@lehins lehins merged commit b2a76bf into master Jan 25, 2023
@iohk-bors iohk-bors bot deleted the lehins/containers-internal-tests branch January 25, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants