Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cabal format #3286

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Cabal format #3286

merged 1 commit into from
Feb 9, 2023

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Feb 8, 2023 •
edited
Loading

Description

We add a check in CI for cabal format, and enforce formatting for all .cabal files in the project.

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu (which can be run with scripts/fourmolize.sh
  • Self-reviewed the diff

@aniketd aniketd force-pushed the aniketd/cabal-format branch from c648b59 to e9b83e7 Compare February 8, 2023 12:03
@aniketd aniketd force-pushed the aniketd/cabal-format branch from 4600f8f to 9e4a67e Compare February 8, 2023 12:47
@aniketd aniketd marked this pull request as ready for review February 8, 2023 12:49
@aniketd aniketd requested a review from a team as a code owner February 8, 2023 12:49
@aniketd aniketd requested review from lehins, Soupstraw, JaredCorduan, teodanciu and TimSheard and removed request for a team February 8, 2023 12:50
lehins
lehins approved these changes Feb 9, 2023
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! ❤️

@aniketd aniketd merged commit d86567a into master Feb 9, 2023
@iohk-bors iohk-bors bot deleted the aniketd/cabal-format branch February 9, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins approved these changes

@Soupstraw Soupstraw Awaiting requested review from Soupstraw

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@teodanciu teodanciu Awaiting requested review from teodanciu

@TimSheard TimSheard Awaiting requested review from TimSheard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aniketd @lehins