Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround ghcup issue on CI #3289

Merged
merged 1 commit into from Feb 9, 2023
Merged

Workaround ghcup issue on CI #3289

merged 1 commit into from Feb 9, 2023

Conversation

lehins
Copy link
Contributor

@lehins lehins commented Feb 9, 2023 •
edited

Description

Yesterday we started getting CI failures due to ghcup hitting an issue on GA ubuntu image. This PR works around it

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu (which can be run with scripts/fourmolize.sh)
  • Cabal files are formatted (which can be done with scripts/cabal-format.sh)
  • Self-reviewed the diff

@lehins lehins requested a review from a team as a code owner February 9, 2023 11:22
@lehins lehins requested a review from aniketd February 9, 2023 11:59
teodanciu
teodanciu approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@teodanciu teodanciu left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and fixes the issue, as it's the only branch making it past Install Haskell gh action step 🚀

@lehins lehins enabled auto-merge February 9, 2023 12:50
@lehins lehins merged commit a2466fd into master Feb 9, 2023
@iohk-bors iohk-bors bot deleted the lehins/fix-ghcup-on-ci branch February 9, 2023 13:12
@JaredCorduan
Copy link
Contributor

thank you @lehins !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teodanciu teodanciu teodanciu approved these changes

@aniketd aniketd Awaiting requested review from aniketd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lehins @JaredCorduan @teodanciu