Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarifying the script integrity hash #3290

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

JaredCorduan
Copy link
Contributor

@JaredCorduan JaredCorduan commented Feb 9, 2023

Description

Clarifying the script integrity hash in the CDDL description:

  • remove the outer square brackets so as to not imply that the bytes are inside of a CBOR array
  • explicitly describe in prose that we are concatenating
  • use the notation from cryptography of double pipe for concatenation
  • make it clear that if there are no datums, that "empty string" here means the empty bytestring, ie that it is omitted.

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu (which can be run with scripts/fourmolize.sh)
  • Cabal files are formatted (which can be done with scripts/cabal-format.sh)
  • Self-reviewed the diff

@JaredCorduan JaredCorduan force-pushed the jc/reword-script-integrity-hash-description branch from 9488a3c to 5473bb8 Compare February 13, 2023 13:55
in the CDDL description
@JaredCorduan JaredCorduan force-pushed the jc/reword-script-integrity-hash-description branch from 5473bb8 to b179fe6 Compare February 16, 2023 12:26
@JaredCorduan JaredCorduan enabled auto-merge (rebase) February 16, 2023 12:27
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@JaredCorduan
Copy link
Contributor Author

The CI failure was the inability to generate a sufficiently long trace for a small-step-semantics test. I am unworried about this and will re-run.

@JaredCorduan JaredCorduan merged commit d86964d into master Feb 16, 2023
@iohk-bors iohk-bors bot deleted the jc/reword-script-integrity-hash-description branch February 16, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants