Switch BHeader memoization to strict ByteString, but keep the field lazy #3298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/fix-bheader-memoization
branch
from
3107a72 to
e616338
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is wrong to have a field used for memoizing the binary representation of the type to be strict, even if the lazy bytestring is used for memoization. It is wrong, because evaluating lazy ByteString to WHNF will force the first chunk of the ByteString, thus causing the first 1KiB of a Block to be immediately serialized upon construction of the BHeader
Checklist
fourmolu(which can be run withscripts/fourmolize.sh)scripts/cabal-format.sh)