Simplify To/FromCBOR instances for DSIGN types #3302
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I assume To/FromCBOR instance for DSIGN were not defined in the same "catch all" way as it is done for all other crypto types (i.e. the way it is defined in this PR) in order to prevent memory locked DSIGN implementation to have To/FromCBOR instances, because that would violate the safety guarantees of locked memory by leaking secrets onto the Haskell heap. However, now that we have a pretty solid memory locked DSIGN implementation we can safely provide those instances for all
SigKeyDSIGN v
,VerKeyDSIGN v
andSigDSIGN v
, because memory locked version will be a totally separate interface with type families namedSigKeyDSIGNM v
,VerKeyDSIGNM v
andSigDSIGNM v
. See IntersectMBO/cardano-base#255Checklist
fourmolu
(which can be run withscripts/fourmolize.sh
)scripts/cabal-format.sh
)