Fix Address deserialization compatibility #3307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
commented
Feb 21, 2023
lehins
force-pushed
the
lehins/lenient-ptr
branch
3 times, most recently
from
c60c491 to
6f01a09
Compare
* Lenient Ptr decoding * Improve BabbageTxOut serialization
lehins
force-pushed
the
lehins/lenient-ptr
branch
from
6f01a09 to
8bcc614
Compare
JaredCorduan
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Starting with Babbage era it is not possible to decode a TxOut with a bad address, such as one that had trailing junk data or a Ptr address with values that are too large or trailed with junk. That being said, prior to Babbage there was a few Ptrs that violated those restrictions and thus need to be supported. This PR fixes this backwards compatibility of retaining buggy behavior for older eras:
Checklist
fourmolu(which can be run withscripts/fourmolize.sh)scripts/cabal-format.sh)