Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nix build #3311

Merged
merged 4 commits into from
Feb 28, 2023
Merged

Fix nix build #3311

merged 4 commits into from
Feb 28, 2023

Conversation

teodanciu
Copy link
Contributor

@teodanciu teodanciu commented Feb 28, 2023

Description

Add your description here, if it fixes a particular issue please provide a
link
to the issue.

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@teodanciu teodanciu changed the title wip Fix nix build Feb 28, 2023
@teodanciu teodanciu marked this pull request as ready for review February 28, 2023 01:39
@teodanciu teodanciu requested a review from a team as a code owner February 28, 2023 01:39
Copy link
Contributor

@dermetfan dermetfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this fixes the evaluation of nix-build -A checks which before this change reported:

error: undefined variable 'extra'

       at /mnt/cephfs/home/dermetfan/projects/development/IOHK/repos/cardano-ledger/nix/util.nix:9:12:

            8|
            9|   inherit (extra)
             |            ^
           10|     recRecurseIntoAttrs

The build itself still does not work though, reporting:

error: builder for '/nix/store/zmji7vwzdblg3vy3a1jbvcpn422l9rfc-cardano-ledger-conway-test-test-cardano-ledger-conway-test-1.0.0.0-check.drv' failed with exit code 1;
       last 10 log lines:
       >       Exception: cddl: createProcess: posix_spawnp: does not exist (No such file or directory)
       >       Use -p '/CDDL roundtrip CostModels/' to rerun this test only.
       >     CDDL roundtrip Redeemers (ConwayEra StandardCrypto):       FAIL
       >       Exception: cddl: createProcess: posix_spawnp: does not exist (No such file or directory)
       >       Use -p '/CDDL roundtrip Redeemers (ConwayEra StandardCrypto)/' to rerun this test only.
       >     CDDL roundtrip AlonzoTx (ConwayEra StandardCrypto):        FAIL
       >       Exception: cddl: createProcess: posix_spawnp: does not exist (No such file or directory)
       >       Use -p '/CDDL roundtrip AlonzoTx (ConwayEra StandardCrypto)/' to rerun this test only.
       >
       > 14 out of 17 tests failed (41.89s)

Not sure if that is in the scope of this PR though, so still approving as this does fix the evaluation.

@teodanciu
Copy link
Contributor Author

teodanciu commented Feb 28, 2023

That's interesting, thank you very much for checking @dermetfan . ( I tested with another derivation which worked, rather than all of them.. )
Looking into it now

@teodanciu
Copy link
Contributor Author

This problem was unrelated to the iohk-nix update...rather nix-build -A tests.cardano-leder-conway-test never actually worked 😬
I think we have to have at least a nightly nix-build job running.

@teodanciu teodanciu merged commit e1ea73a into master Feb 28, 2023
@iohk-bors iohk-bors bot deleted the td/fix-nix-build branch February 28, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants