Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve nightly builds #3316

Merged
merged 3 commits into from
Mar 6, 2023
Merged

Improve nightly builds #3316

merged 3 commits into from
Mar 6, 2023

Conversation

teodanciu
Copy link
Contributor

@teodanciu teodanciu commented Feb 28, 2023

Description

A few improvements to nightly builds:

  • Rename the Github action run to make it clear it's a nightly build - hopefully this will make it easier to distinguish it in the emails if it fails
  • Add new substituters (so that we can use caching in github actions running nix )
  • Run nix-build and nix-shell as part of nightly builds, so we are aware at latest the next day if they've been broken

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@teodanciu teodanciu force-pushed the td/improve-nightly-builds branch 7 times, most recently from 94d126b to 9fb4fda Compare March 2, 2023 17:11
so that it's easier to see when nightly builds are failing
@teodanciu teodanciu force-pushed the td/improve-nightly-builds branch 2 times, most recently from 8908536 to d51e38e Compare March 2, 2023 17:34
@teodanciu teodanciu force-pushed the td/improve-nightly-builds branch from f37f681 to 81d371f Compare March 3, 2023 09:04
@teodanciu teodanciu marked this pull request as ready for review March 3, 2023 09:09
@teodanciu teodanciu requested a review from a team as a code owner March 3, 2023 09:09
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!!

@teodanciu teodanciu merged commit 6c864ac into master Mar 6, 2023
@iohk-bors iohk-bors bot deleted the td/improve-nightly-builds branch March 6, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants