Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust GovernanceProcedure #3330

Merged
merged 5 commits into from
Mar 16, 2023
Merged

Adjust GovernanceProcedure #3330

merged 5 commits into from
Mar 16, 2023

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Mar 14, 2023 •
edited
Loading

Description

Change the way GovernanceProcedure is represented for code clarity:

  • Renamed Vote type to VotingProcedure
  • Add ProposalProcedure
  • Use VotingProcedure and ProposalProcedure in GovernanceProcedure
  • Rename VoteDecision to Vote. Rename No/Yes -> VoteNo/VoteYes.
  • Remove GovernanceMetadata in favor of Anchor

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the CHANGELOG.md for affected package
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins requested a review from Soupstraw March 14, 2023 16:41
@lehins lehins force-pushed the lehins/adjust-governance-procedure branch 3 times, most recently from 054df00 to 02008f0 Compare March 15, 2023 01:22
@lehins lehins force-pushed the lehins/adjust-governance-procedure branch from 02008f0 to c0bd324 Compare March 15, 2023 14:31
@lehins lehins force-pushed the lehins/adjust-governance-procedure branch from c0bd324 to f21e893 Compare March 15, 2023 14:34
@lehins lehins force-pushed the lehins/adjust-governance-procedure branch from c540f98 to 4615e12 Compare March 15, 2023 16:43
JaredCorduan
JaredCorduan approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lehins added 5 commits March 16, 2023 02:09
@lehins
Adjust GovernanceProcedure:
e427aed 
* Renamed `Vote` type to `VotingProcedure`
* Add `ProposalProcedure`
* Use `VotingProcedure` and `ProposalProcedure` in `GovernanceProcedure`
* Rename `VoteDecision` to `Vote`. Rename `No`/`Yes` -> `VoteNo`/`VoteYes`.
* Remove `GovernanceMetadata` in favor of `Anchor`
@lehins
Split GovernanceProcedure into VotingProcedure and ProposalProcedure …
f611cdf 
…in TxBody
@lehins
Forbid zero coin in the TxOut in CDDL
522dcde
@lehins
Fix Rational serialization and deserialization
568a921
@lehins
Fix CDDL spec for GovernanceAction
2f81c9b
@lehins lehins force-pushed the lehins/adjust-governance-procedure branch from 1ae3d0f to 2f81c9b Compare March 15, 2023 23:09
@lehins lehins enabled auto-merge March 15, 2023 23:10
@lehins lehins merged commit d43105a into master Mar 16, 2023
@iohk-bors iohk-bors bot deleted the lehins/adjust-governance-procedure branch March 16, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredCorduan JaredCorduan JaredCorduan approved these changes

@Soupstraw Soupstraw Soupstraw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lehins @JaredCorduan @Soupstraw