enforce unique elements in CBOR sets, ver. 9 #3331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaredCorduan
force-pushed
the
jc/no-dups-in-sets
branch
2 times, most recently
from
5697eb4 to
2283560
Compare
lehins
requested changes
Mar 15, 2023
libs/cardano-ledger-binary/test/Test/Cardano/Ledger/Binary/Failure.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-binary/test/Test/Cardano/Ledger/Binary/Failure.hs
Outdated
Show resolved
Hide resolved
lehins
reviewed
Mar 15, 2023
lehins
reviewed
Mar 15, 2023
libs/cardano-ledger-binary/test/Test/Cardano/Ledger/Binary/Success.hs
Outdated
Show resolved
Hide resolved
lehins
reviewed
Mar 15, 2023
libs/cardano-ledger-binary/test/Test/Cardano/Ledger/Binary/Success.hs
Outdated
Show resolved
Hide resolved
lehins
reviewed
Mar 15, 2023
libs/cardano-ledger-binary/test/Test/Cardano/Ledger/Binary/Success.hs
Outdated
Show resolved
Hide resolved
lehins
reviewed
Mar 15, 2023
libs/cardano-ledger-binary/test/Test/Cardano/Ledger/Binary/Success.hs
Outdated
Show resolved
Hide resolved
JaredCorduan
force-pushed
the
jc/no-dups-in-sets
branch
2 times, most recently
from
a90c17a to
20e6602
Compare
lehins
approved these changes
Mar 16, 2023
libs/cardano-ledger-binary/test/Test/Cardano/Ledger/Binary/Success.hs
Outdated
Show resolved
Hide resolved
JaredCorduan
force-pushed
the
jc/no-dups-in-sets
branch
from
20e6602 to
ccccb87
Compare
Starting in major version 9, we now raise a decoding error if a CBOR set contains duplicate keys. Additionally, we allow (but do not require) the set tag.
JaredCorduan
force-pushed
the
jc/no-dups-in-sets
branch
from
ccccb87 to
c5e3004
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Starting in major version 9, we now raise a decoding error if a CBOR set contains duplicate keys. Additionally, we allow (but do not require) the set tag.
resolves #3340
Checklist
CHANGELOG.mdfor affected packagefourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)