Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve roundtrip CBOR serialization failure testing functions: #3332

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Improve roundtrip CBOR serialization failure testing functions: #3332

merged 1 commit into from
Mar 15, 2023

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Mar 14, 2023 •
edited
Loading

Description

  • Renamed:
    • roundTripAnnFailureRangeExpectation -> roundTripAnnRangeFailureExpectation
    • roundTripFailureCborRangeExpectation -> roundTripCborRangeFailureExpectation
    • roundTripAnnFailureRangeExpectation -> roundTripAnnRangeFailureExpectation
  • Added:
    • embedTripFailureExpectation
    • embedTripRangeFailureExpectation
    • roundTripRangeFailureExpectation

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the CHANGELOG.md for affected package
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins mentioned this pull request Mar 15, 2023
Merged
7 tasks
JaredCorduan
JaredCorduan approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lehins lehins force-pushed the lehins/embed-trip-failure branch 2 times, most recently from 310e438 to c6e9165 Compare March 15, 2023 19:26
@lehins
Fix MultiAsset tests and improve CBOR deserialization failure testing…
fea4c29 
… functions:

* Renamed:
  * `roundTripAnnFailureRangeExpectation` -> `roundTripAnnRangeFailureExpectation`
  * `roundTripFailureCborRangeExpectation` -> `roundTripCborRangeFailureExpectation`
  * `roundTripAnnFailureRangeExpectation` -> `roundTripAnnRangeFailureExpectation`
* Added:
  * `embedTripFailureExpectation`
  * `embedTripRangeFailureExpectation`
  * `roundTripRangeFailureExpectation`

Also fix MultiAsset tests
@lehins lehins force-pushed the lehins/embed-trip-failure branch from c6e9165 to fea4c29 Compare March 15, 2023 19:32
@lehins lehins enabled auto-merge March 15, 2023 19:32
@lehins lehins merged commit edbb00e into master Mar 15, 2023
@iohk-bors iohk-bors bot deleted the lehins/embed-trip-failure branch March 15, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredCorduan JaredCorduan JaredCorduan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lehins @JaredCorduan