Fix MultiAsset generation #3347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniketd
force-pushed
the
aniketd/ci-failure-asset-name
branch
2 times, most recently
from
e29049b to
9bfd2e2
Compare
JaredCorduan
approved these changes
Mar 22, 2023
lehins
requested changes
Mar 22, 2023
There was a problem hiding this comment.
Great job on investigating this problem and figuring out the value of 910. Taking a quick peek at the compaction implementation it does seem to be the correct value indeed.
There are some problems that I commented on in the PR itself, but the overall direction is totally correct.
We are still missing fixes to the deserializer, but I am sure you knew this already anyways.
aniketd
force-pushed
the
aniketd/ci-failure-asset-name
branch
2 times, most recently
from
c6807d3 to
e20ec44
Compare
aniketd
force-pushed
the
aniketd/ci-failure-asset-name
branch
from
e20ec44 to
368b1a2
Compare
Closed
lehins
requested changes
Mar 24, 2023
libs/cardano-ledger-binary/testlib/Test/Cardano/Ledger/Binary/RoundTrip.hs
Outdated
Show resolved
Hide resolved
lehins
reviewed
Mar 27, 2023
lehins
reviewed
Mar 27, 2023
lehins
reviewed
Mar 27, 2023
lehins
reviewed
Mar 27, 2023
aniketd
commented
Mar 27, 2023
aniketd
commented
Mar 27, 2023
lehins
reviewed
Mar 27, 2023
lehins
reviewed
Mar 27, 2023
aniketd
force-pushed
the
aniketd/ci-failure-asset-name
branch
from
ea040f7 to
dcd5ed6
Compare
aniketd
force-pushed
the
aniketd/ci-failure-asset-name
branch
2 times, most recently
from
b22ea27 to
88c70d6
Compare
lehins
requested changes
Mar 29, 2023
aniketd
force-pushed
the
aniketd/ci-failure-asset-name
branch
from
88c70d6 to
e37889d
Compare
aniketd
force-pushed
the
aniketd/ci-failure-asset-name
branch
from
e37889d to
4228466
Compare
aniketd
force-pushed
the
aniketd/ci-failure-asset-name
branch
from
4228466 to
f362139
Compare
lehins
approved these changes
Apr 13, 2023
aniketd
force-pushed
the
aniketd/ci-failure-asset-name
branch
from
f362139 to
1a77632
Compare
Serialization version inside the test differed from the one used in `setMinCoinTxOut`. Both should be drawing the protocol version from the supplied PParams
lehins
force-pushed
the
aniketd/ci-failure-asset-name
branch
from
1a77632 to
a018a68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #3312
Checklist
CHANGELOG.mdfor affected packagefourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)