Translate bad Ptrs to valid Ptrs during translation to Conway.
#3360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/truncate-ptrs-upon-translation
branch
from
ca54936 to
22905ce
Compare
JaredCorduan
approved these changes
Mar 27, 2023
lehins
force-pushed
the
lehins/truncate-ptrs-upon-translation
branch
2 times, most recently
from
2c23f6b to
af69281
Compare
Bad pointers and ugly addresses are not allowed in transactions starting with Babbage era. However, Ptr's that did land on chain in prior eras are still present in the LedgerState. Thanks to deprecation of `Ptr`s we can simplify the Ptr decoding logic, but only after the bad ones have been translated.
lehins
force-pushed
the
lehins/truncate-ptrs-upon-translation
branch
from
af69281 to
5fe9e9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bad pointers and ugly addresses are not allowed in transactions starting with Babbage era. However, Ptr's that did land on chain in prior eras are still present in the LedgerState. Thanks to deprecation of
Ptrs we can simplify the Ptr decoding logic, but only after the bad ones have been translated.Description
Add your description here, if it fixes a particular issue please provide a
link
to the issue.
Checklist
CHANGELOG.mdfor affected packagefourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)