Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor api improvements #3366

Merged
merged 8 commits into from Apr 3, 2023
Merged

Minor api improvements #3366

merged 8 commits into from Apr 3, 2023

Conversation

lehins
Copy link
Contributor

@lehins lehins commented Apr 3, 2023 •
edited

Description

  • Rename TxId field from _unTxId to unTxId
  • Some TxAuxData realeted cleanups:
    • Remove redundant pattern synonym AllegraTxAuxData' and AlonzoTxAuxData'
    • Hide internal AllegraTxAuxDataRaw constructor with atadrMetadata and atadrTimelock
      record fields.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the CHANGELOG.md for affected package
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins requested a review from JaredCorduan April 3, 2023 16:26
JaredCorduan
JaredCorduan approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lehins
Add deprecated _unTxId function
32072df
@lehins
Fix Conway CDDL test for Coin
6e828f8 
Starting with Conway we no longer allow zero value. However `Coin`,
whenever used in other contexts, eg. fees, params, etc. are allowed to
be zero. Therefore we added a new CDDL type `positive_coin`, which is used
in `Value` and consequently in `TxOut`s. This commit fixes the test
only, implementation is totally correct
@lehins lehins enabled auto-merge April 3, 2023 21:08
@lehins lehins merged commit 6d8c5b8 into master Apr 3, 2023
23 of 25 checks passed
@iohk-bors iohk-bors bot deleted the lehins/minor-api-improvements branch April 3, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredCorduan JaredCorduan JaredCorduan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lehins @JaredCorduan