Adjust CostModel's FromJSON instance
#3367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…w style: * Addition of `costModelToMap`, `costModelFromMap` and `costModelParamNames` * Made it possible for `FromJSON` to decode `CostModels` both as the new approach: 1. as a list of cost models values, 2. and the old approach of mapping from the parameter name to the cost model value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It turns out cardano-node relies on JSON for CostModel for PlutusV2 to also contain the parameter names, not just a list of values. This PR implements this backwards compatibility in a forward compatible way.
costModelToMap,costModelFromMapandcostModelParamNamesFromJSONto decodeCostModelsboth as the new approach:Checklist
CHANGELOG.mdfor affected packagefourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)