Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MapMember and NotMapMember #3386

Merged
merged 5 commits into from
Apr 25, 2023
Merged

MapMember and NotMapMember #3386

merged 5 commits into from
Apr 25, 2023

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Apr 19, 2023 •
edited
Loading

Description

Implementation of MapMember and NotMapMember predicates.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd requested a review from TimSheard April 19, 2023 11:28
@aniketd aniketd force-pushed the aniketd/constraint-generation branch 2 times, most recently from a046872 to f43847e Compare April 19, 2023 12:18
@TimSheard TimSheard force-pushed the ts-constraints-for-tx branch from 22c95ba to 9bd0240 Compare April 19, 2023 22:48
@aniketd aniketd force-pushed the aniketd/constraint-generation branch from f43847e to c76e8dc Compare April 20, 2023 15:45
TimSheard
TimSheard reviewed Apr 20, 2023
View reviewed changes
Copy link
Contributor

@TimSheard TimSheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few issues to deal with we want the pair (k,v) to be in Map.toList m

libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Ast.hs Outdated Show resolved Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Ast.hs Outdated Show resolved Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Rewrite.hs Outdated Show resolved Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Solver.hs Outdated Show resolved Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Solver.hs Outdated Show resolved Hide resolved
@aniketd aniketd force-pushed the aniketd/constraint-generation branch from 75469d5 to 65e9dcd Compare April 25, 2023 15:17
TimSheard
TimSheard reviewed Apr 25, 2023
View reviewed changes
Copy link
Contributor

@TimSheard TimSheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to fix the solving for MapMember when the map is known. The answer then are then some sort of lookup.

@TimSheard TimSheard merged commit ffacf69 into ts-constraints-for-tx Apr 25, 2023
@iohk-bors iohk-bors bot deleted the aniketd/constraint-generation branch April 25, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Soupstraw Soupstraw Soupstraw left review comments

@TimSheard TimSheard TimSheard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aniketd @TimSheard @Soupstraw