reinstate our two tickf optimizations #3390
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While preparing for a new release, we had to remove our two
TICKF
optimizations: #3375The problem was that a local network test in cardano-node was failing, namely
cardano-testnet
.The problem, however, was not in the optimizations, but rather in the test setup:
https://github.com/input-output-hk/ouroboros-network/blob/8685fc4b08cd5f11735768d60da921628602b630/ouroboros-consensus-shelley/src/Ouroboros/Consensus/Shelley/Node/TPraos.hs#L336-L344
The problem is that the inserted
mark
snapshot is now not enough to quick-start the network, the pool distribution also needs to quick-started:I verified this by running
cardano-testnet
with a modified ledger and consensus as described above.We can now restore the optimizations in ledger, but we still need to either fix
registerGenesisStaking
as described above, or do something safer to prevent future mistakes like this.Checklist
CHANGELOG.md
for affected package.cabal
files are updatedfourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)