Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conway instances added #3395

Merged
merged 1 commit into from
May 1, 2023
Merged

conway instances added #3395

merged 1 commit into from
May 1, 2023

Conversation

JaredCorduan
Copy link
Contributor

Description

I added instances for ConwayDelegsPredFailure which are required to integrate the latest ledger into consensus: Typeable, NoThunks, EncCBOR, DecCBOR, and Arbitary. The last three, however, are undefined.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

lehins
lehins approved these changes Apr 27, 2023
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Delegs.hs Outdated Show resolved Hide resolved
@JaredCorduan JaredCorduan force-pushed the jc/conway-instances branch 2 times, most recently from e9fc1b8 to 631519f Compare April 27, 2023 20:22
@JaredCorduan
Copy link
Contributor Author

@lehins I've removed all the undefineds since you reviewed. I'll wait for another 👍 from you before I merge.

lehins
lehins approved these changes Apr 27, 2023
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Some minor suggestions

eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Delegs.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Delegs.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Delegs.hs Outdated Show resolved Hide resolved
eras/conway/impl/CHANGELOG.md Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Delegs.hs Show resolved Hide resolved
@JaredCorduan JaredCorduan force-pushed the jc/conway-instances branch from 3b4408d to 328e003 Compare May 1, 2023 11:42
@JaredCorduan JaredCorduan force-pushed the jc/conway-instances branch from 328e003 to 6887f8a Compare May 1, 2023 17:16
@JaredCorduan JaredCorduan enabled auto-merge (rebase) May 1, 2023 17:16
@JaredCorduan JaredCorduan merged commit ad628a5 into master May 1, 2023
@iohk-bors iohk-bors bot deleted the jc/conway-instances branch May 1, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JaredCorduan @lehins