Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename DCert -> TxCert #3421

Merged
merged 3 commits into from
May 12, 2023
Merged

Rename DCert -> TxCert #3421

merged 3 commits into from
May 12, 2023

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented May 11, 2023 •
edited
Loading

Description

Recently in #3387 we introduced a type family. In order to keep it consistent with all other type families that go into a transaction it was decided to rename DCert to a TxCert

Modules that contain the classes, instances and type families where also renamed to TxCert

There are no semantic changes in this PR, just the renames.

Also all of the versions where bumped, since there is currently ledger release happening to CHaPs.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated (See RELEASING.md)
  • Any changes are noted in the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins force-pushed the lehins/rename-dcerts branch 2 times, most recently from c2e7a34 to 69895b7 Compare May 11, 2023 22:28
@lehins lehins requested a review from JaredCorduan May 11, 2023 23:27
JaredCorduan
JaredCorduan approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for continually getting us closer and closer to uniformity!

The changelogs are going to need some help, as I mentioned in another comment, but I can do that in a follow up PR.

lehins added 3 commits May 12, 2023 19:55
@lehins
Rename DCert to TxCert for all eras.
f72999c 
Also rename modules from `Delegation` to `TxCert`

This is needed for consistency with other type families that are part of
the transaction, `TxOut`, `TxBody`, `TxAuxData`, etc.
@lehins
Add two modules for backwards compatibility
fc76ad0
@lehins
Update versions and fix changelogs
c0dee65
@lehins lehins force-pushed the lehins/rename-dcerts branch from 69895b7 to c0dee65 Compare May 12, 2023 16:56
@lehins lehins enabled auto-merge May 12, 2023 16:57
@lehins lehins merged commit 5df3c59 into master May 12, 2023
@iohk-bors iohk-bors bot deleted the lehins/rename-dcerts branch May 12, 2023 18:50
@JaredCorduan JaredCorduan mentioned this pull request May 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredCorduan JaredCorduan JaredCorduan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lehins @JaredCorduan