Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send slack notification if nightly build failed #3472

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

teodanciu
Copy link
Contributor

@teodanciu teodanciu commented Jun 5, 2023

Description

This will send a notification on #ledger-internal Slack if the nightly build fails.

For this to work, we need another entry added to github settings -> Security -> Secrets and variables -> Actions -> Repository Secrets , namely : SLACK_WEBHOOK_URL
The value for this should be set to the Webhook URL of the app

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@teodanciu teodanciu requested a review from a team as a code owner June 5, 2023 18:18
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @teodanciu !

@JaredCorduan JaredCorduan force-pushed the td/nightly-failure-notifications branch from fe23787 to 8548aca Compare June 6, 2023 20:22
@teodanciu teodanciu force-pushed the td/nightly-failure-notifications branch from 8548aca to 6e42f6d Compare June 7, 2023 09:24
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@teodanciu teodanciu force-pushed the td/nightly-failure-notifications branch from 6e42f6d to e4cba66 Compare June 8, 2023 14:23
@teodanciu
Copy link
Contributor Author

@JaredCorduan maybe tomorrow during the meeting we could add these settings to github together, so we can merge this?

@JaredCorduan
Copy link
Contributor

@JaredCorduan maybe tomorrow during the meeting we could add these settings to github together, so we can merge this?

great idea!

@lehins
Copy link
Contributor

lehins commented Jul 17, 2023

SLACK_WEBHOOK_URL is now set.

@teodanciu teodanciu requested review from a team as code owners July 18, 2023 10:37
@teodanciu teodanciu force-pushed the td/nightly-failure-notifications branch from d696275 to 9d4ce14 Compare July 18, 2023 10:41
@teodanciu teodanciu merged commit 5af3ad9 into master Jul 18, 2023
14 checks passed
@iohk-bors iohk-bors bot deleted the td/nightly-failure-notifications branch July 18, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants