Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed TALLY to GOV #3520

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Renamed TALLY to GOV #3520

merged 1 commit into from
Jul 19, 2023

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Jul 4, 2023

Description

This PR applies the following substitutions:

s/Tally/Gov/g
s/VDel/GovCert/g

I also renamed

eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Tally.hs -> Gov.hs
eras/conway/impl/src/Cardano/Ledger/Conway/Rules/VDel.hs -> GovCert.hs

.. and updated the Conway cabal file with the new paths.

resolves #3515
resolves #3505

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw requested a review from lehins July 4, 2023 14:57
@Soupstraw Soupstraw force-pushed the jj/tally-rename branch 12 times, most recently from 3f2de0f to ef75a8d Compare July 6, 2023 13:52
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but still needs a little work

libs/cardano-ledger-core/src/Cardano/Ledger/CertState.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Cert.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Ledger.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Ledger.hs Outdated Show resolved Hide resolved
eras/mary/impl/CHANGELOG.md Outdated Show resolved Hide resolved
@Soupstraw Soupstraw force-pushed the jj/tally-rename branch 3 times, most recently from 79cee4f to dd1110e Compare July 7, 2023 11:27
@Soupstraw Soupstraw requested a review from lehins July 7, 2023 11:28
@Soupstraw Soupstraw force-pushed the jj/tally-rename branch 11 times, most recently from a55b8bc to 8515106 Compare July 7, 2023 11:41
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some versioning stuff, otherwise looks great

libs/cardano-ledger-api/CHANGELOG.md Outdated Show resolved Hide resolved
libs/cardano-ledger-pretty/CHANGELOG.md Show resolved Hide resolved
eras/conway/impl/CHANGELOG.md Outdated Show resolved Hide resolved
@Soupstraw Soupstraw force-pushed the jj/tally-rename branch 6 times, most recently from bea7ce0 to 784c4f8 Compare July 18, 2023 14:06
@Soupstraw Soupstraw requested a review from lehins July 18, 2023 14:08
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just need a rebase on master and one comment from Teodora

@lehins lehins added this to In progress in Conway via automation Jul 18, 2023
@lehins lehins added the conway label Jul 18, 2023
@lehins lehins removed this from In progress in Conway Jul 18, 2023
@lehins lehins removed the conway label Jul 18, 2023
@Soupstraw Soupstraw force-pushed the jj/tally-rename branch 2 times, most recently from 0c6c8b9 to e89faeb Compare July 19, 2023 09:54
@Soupstraw Soupstraw enabled auto-merge (squash) July 19, 2023 09:55
@teodanciu
Copy link
Contributor

@Soupstraw Not sure if you've seen that there is a little compilation error probably after some renamings? Just mentioning because I see you've enabled automerge, so not sure if you're aware of the problem

@Soupstraw Soupstraw merged commit d8b622c into master Jul 19, 2023
11 of 12 checks passed
@iohk-bors iohk-bors bot deleted the jj/tally-rename branch July 19, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename TALLY to GOV Rename VDEL to GOVCERT
3 participants