Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce the non-zero exit code in the shell prompt #3546

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

teodanciu
Copy link
Contributor

since it's been removed in the transition to flakes

Description

Appends the error code of a failed command ran within the nix shell

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@teodanciu teodanciu requested review from a team as code owners July 18, 2023 10:58
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

since it's been removed in the transition to flakes
@lehins lehins force-pushed the td/errorcode-in-nix-shell-prompt branch from 6600fbc to 30acd4a Compare July 18, 2023 21:50
@lehins lehins enabled auto-merge July 18, 2023 21:50
@lehins lehins merged commit 22e2097 into master Jul 19, 2023
12 checks passed
@iohk-bors iohk-bors bot deleted the td/errorcode-in-nix-shell-prompt branch July 19, 2023 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants