Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spendableInputsTxBodyF and fix requiring witnesses for refInputs #3558

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

lehins
Copy link
Contributor

@lehins lehins commented Jul 20, 2023

Description

Restructure of collecting required witnesses by accident also enforced to require witnesses for reference inputs in #3425

This PR fixes the problem by adding spendableInputsTxBodyF

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Something good came from this problem: clarifying what "spendableInput" is for each era. I think the existence of this concept as a lens will be useful to help preventing similar issues.

@lehins lehins force-pushed the lehins/add-spendable-inputs branch from 699d559 to 366349e Compare July 20, 2023 19:15
@lehins lehins enabled auto-merge July 20, 2023 19:44
@lehins lehins merged commit ba49a78 into master Jul 20, 2023
9 of 11 checks passed
@iohk-bors iohk-bors bot deleted the lehins/add-spendable-inputs branch July 20, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants