Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement half of the TICKF rule. #3571

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Jul 24, 2023

Description

Copy NEWEPOCH and TICKF relevant functionality from Shelley to Conway.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins mentioned this pull request Jul 24, 2023
9 tasks
@lehins
Copy link
Collaborator Author

lehins commented Jul 25, 2023

The fix in this PR has been verified on SanchoNet and now released in cardano-ledger-conway-1.6.3.0

@lehins lehins requested a review from Soupstraw July 25, 2023 10:16
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - same as Shelley TICKF without the MIR, UPEC and GenesisDelegs stuff.
Maybe would be good to have some TODO so we dont' forget about the other half, but there's probably a ticket for it

@lehins lehins force-pushed the lehins/fixup-conway-tickf-rule branch from 399d800 to e1553c6 Compare July 25, 2023 15:51
@lehins lehins enabled auto-merge July 25, 2023 15:51
@lehins lehins merged commit 9d3cd39 into master Jul 25, 2023
@iohk-bors iohk-bors bot deleted the lehins/fixup-conway-tickf-rule branch July 25, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants