Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update top-level CHANGELOG.md with cardano-node relevant changes #3573

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

lehins
Copy link
Contributor

@lehins lehins commented Jul 25, 2023

Description

Ledger team still needs to provide high level overview of the changes that go into each major cardano-node release. Might as well record them in the cardano-ledger repository as well.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins requested a review from teodanciu July 25, 2023 13:32
CHANGELOG.md Outdated Show resolved Hide resolved
@lehins lehins force-pushed the lehins/global-changelog-revival branch from 6db7695 to 67e2ad3 Compare July 25, 2023 13:38
@lehins lehins requested a review from teodanciu July 25, 2023 13:46
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice to have this!

@lehins lehins force-pushed the lehins/global-changelog-revival branch from 67e2ad3 to ff7083a Compare July 25, 2023 14:38
@lehins lehins force-pushed the lehins/global-changelog-revival branch from ff7083a to 6b5a486 Compare July 26, 2023 08:29
@lehins lehins enabled auto-merge July 26, 2023 08:29
@lehins lehins merged commit 2fafe0b into master Jul 26, 2023
11 of 12 checks passed
@iohk-bors iohk-bors bot deleted the lehins/global-changelog-revival branch July 26, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants