Improve clarity and performance of collateral Non-ADA validation: #3574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/avoid-collateral-validation-when-no-validation
branch
from
fb3fc5d to
af267ac
Compare
teodanciu
reviewed
Jul 25, 2023
8 tasks
Predicate checks are lazy in their argument, because it is possible to run STS rules without doing any validation. Current Non-Ada validation ignored this capability and forced validation regardless of the options provided to the STS runner. This commit also improves the clarity on the implementation of validation, by explaining all possible cases.
lehins
force-pushed
the
lehins/avoid-collateral-validation-when-no-validation
branch
from
af267ac to
41882c7
Compare
iohk-bors
bot
deleted the
lehins/avoid-collateral-validation-when-no-validation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Predicate checks are lazy in their argument, because it is possible to run STS rules without doing any validation. Current Non-Ada validation ignored this capability and forced validation regardless of the options provided to the STS runner, which this PR fixes.
This commit also improves the clarity on the implementation of validation, by explaining all possible cases.
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)