Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional Anchor to ConwayRegDRep #3576

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Add optional Anchor to ConwayRegDRep #3576

merged 1 commit into from
Jul 27, 2023

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Jul 26, 2023 •
edited

Description

Closes #3569

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd force-pushed the aniketd/optional-anchor-to-drep-reg branch from c5a1862 to e058fb0 Compare July 26, 2023 10:55
@aniketd aniketd force-pushed the aniketd/optional-anchor-to-drep-reg branch from e058fb0 to 4a981c9 Compare July 26, 2023 10:56
lehins
lehins approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to be changed to StrictMaybe

Otherwise looks good

eras/conway/impl/src/Cardano/Ledger/Conway/TxCert.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/TxCert.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/TxCert.hs Outdated Show resolved Hide resolved
@aniketd aniketd force-pushed the aniketd/optional-anchor-to-drep-reg branch from 4a981c9 to a5283b5 Compare July 27, 2023 10:00
@aniketd aniketd force-pushed the aniketd/optional-anchor-to-drep-reg branch from a5283b5 to 2df18f1 Compare July 27, 2023 10:03
@aniketd aniketd enabled auto-merge (rebase) July 27, 2023 10:03
@lehins lehins disabled auto-merge July 27, 2023 12:05
@lehins lehins enabled auto-merge July 27, 2023 12:42
@lehins lehins merged commit fb37bc7 into master Jul 27, 2023
12 checks passed
@iohk-bors iohk-bors bot deleted the aniketd/optional-anchor-to-drep-reg branch July 27, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins approved these changes

@teodanciu teodanciu Awaiting requested review from teodanciu

@TimSheard TimSheard Awaiting requested review from TimSheard

@Soupstraw Soupstraw Awaiting requested review from Soupstraw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add optional Anchor to DRep registration certificate
2 participants
@aniketd @lehins