-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move PParams
to GovState
#3577
Move PParams
to GovState
#3577
Conversation
5f339a7
to
cc51978
Compare
14e6474
to
8bbd81c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do a full review once it is out of draft, but this looks great!
eras/shelley/test-suite/src/Test/Cardano/Ledger/Shelley/Rules/Chain.hs
Outdated
Show resolved
Hide resolved
e15d5e5
to
344a493
Compare
deb42a8
to
914613b
Compare
914613b
to
cb2e630
Compare
60a657e
to
e2b25d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Decoder needs adjusting, but otherwise this is awesome.
eras/shelley/impl/src/Cardano/Ledger/Shelley/LedgerState/Types.hs
Outdated
Show resolved
Hide resolved
eras/shelley/impl/testlib/Test/Cardano/Ledger/Shelley/Binary/Golden.hs
Outdated
Show resolved
Hide resolved
eras/shelley/impl/src/Cardano/Ledger/Shelley/LedgerState/Types.hs
Outdated
Show resolved
Hide resolved
5438242
to
e6bb392
Compare
e6bb392
to
0d4ead8
Compare
0d4ead8
to
26b15f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! Thank you!
Description
closes #3550
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)