Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PParams to GovState #3577

Merged
merged 6 commits into from
Aug 7, 2023
Merged

Move PParams to GovState #3577

merged 6 commits into from
Aug 7, 2023

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Jul 26, 2023

Description

closes #3550

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw force-pushed the jj/pparams-to-govstate branch 2 times, most recently from 5f339a7 to cc51978 Compare July 26, 2023 14:02
@Soupstraw Soupstraw force-pushed the jj/pparams-to-govstate branch 14 times, most recently from 14e6474 to 8bbd81c Compare July 31, 2023 15:34
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do a full review once it is out of draft, but this looks great!

@Soupstraw Soupstraw force-pushed the jj/pparams-to-govstate branch 5 times, most recently from e15d5e5 to 344a493 Compare August 1, 2023 15:11
@Soupstraw Soupstraw marked this pull request as ready for review August 1, 2023 15:23
@Soupstraw Soupstraw force-pushed the jj/pparams-to-govstate branch 2 times, most recently from deb42a8 to 914613b Compare August 2, 2023 09:40
@Soupstraw Soupstraw force-pushed the jj/pparams-to-govstate branch 7 times, most recently from 60a657e to e2b25d0 Compare August 3, 2023 10:14
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!
Decoder needs adjusting, but otherwise this is awesome.

@Soupstraw Soupstraw force-pushed the jj/pparams-to-govstate branch 3 times, most recently from 5438242 to e6bb392 Compare August 3, 2023 14:05
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you!

@lehins lehins enabled auto-merge August 7, 2023 15:11
@lehins lehins merged commit 7869220 into master Aug 7, 2023
12 checks passed
@iohk-bors iohk-bors bot deleted the jj/pparams-to-govstate branch August 7, 2023 16:10
@lehins lehins mentioned this pull request Aug 17, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move PParams into the GovState
2 participants