Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CC Cold Key a Credential #3581

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Jul 26, 2023

Description

Resolves #3564

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Couple of suggestions and you are still missing changes to the CDDL spec

eras/conway/impl/src/Cardano/Ledger/Conway/TxCert.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/TxCert.hs Outdated Show resolved Hide resolved
@aniketd aniketd force-pushed the aniketd/cc-coldkey-credential branch from 37eb7c5 to b63939f Compare July 27, 2023 10:53
@aniketd aniketd requested a review from lehins July 27, 2023 10:54
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lehins lehins enabled auto-merge July 27, 2023 11:19
@lehins lehins force-pushed the aniketd/cc-coldkey-credential branch from b63939f to 197c441 Compare July 27, 2023 12:45
@aniketd aniketd disabled auto-merge July 27, 2023 15:12
@aniketd aniketd merged commit eb33a32 into master Jul 27, 2023
@aniketd aniketd deleted the aniketd/cc-coldkey-credential branch July 27, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constitutional Commitee Cold should be a Credential
2 participants