Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CurrentTreasuryValue to TxBody #3586

Merged
merged 3 commits into from
Jul 28, 2023
Merged

Add CurrentTreasuryValue to TxBody #3586

merged 3 commits into from
Jul 28, 2023

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Jul 28, 2023 •
edited
Loading

Description

Resolves #3536

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd force-pushed the lehins/add-txbody-treasury-field branch from 4d6ec59 to c7e2d6e Compare July 28, 2023 10:52
@aniketd aniketd requested review from lehins, Soupstraw, teodanciu and TimSheard and removed request for lehins July 28, 2023 10:53
@aniketd aniketd force-pushed the lehins/add-txbody-treasury-field branch from c7e2d6e to 464d830 Compare July 28, 2023 11:01
lehins
lehins requested changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one mistake, otherwise looks good.

eras/conway/impl/CHANGELOG.md Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/TxBody.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/TxBody.hs Outdated Show resolved Hide resolved
@aniketd aniketd force-pushed the lehins/add-txbody-treasury-field branch from 464d830 to 087dd63 Compare July 28, 2023 13:33
@aniketd aniketd requested a review from lehins July 28, 2023 13:33
@aniketd aniketd force-pushed the lehins/add-txbody-treasury-field branch from 087dd63 to d44dc7e Compare July 28, 2023 13:36
lehins
lehins approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lehins lehins force-pushed the lehins/add-txbody-treasury-field branch from d44dc7e to e8a11f9 Compare July 28, 2023 13:44
@lehins lehins enabled auto-merge (squash) July 28, 2023 13:44
@lehins lehins force-pushed the lehins/add-txbody-treasury-field branch from e8a11f9 to 959c58a Compare July 28, 2023 15:37
@lehins lehins merged commit d3fa03a into master Jul 28, 2023
@iohk-bors iohk-bors bot deleted the lehins/add-txbody-treasury-field branch July 28, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins approved these changes

@Soupstraw Soupstraw Awaiting requested review from Soupstraw

@teodanciu teodanciu Awaiting requested review from teodanciu

@TimSheard TimSheard Awaiting requested review from TimSheard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add current treasury amount information to the transaction
2 participants
@aniketd @lehins