Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conway txinfo #3593

Merged
merged 5 commits into from
Aug 1, 2023
Merged

Conway txinfo #3593

merged 5 commits into from
Aug 1, 2023

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Aug 1, 2023

Description

This PR provides a collection of minor, but valuable improvements:

  • Translate all pre-conway features, thus making some parts of PlutusV3 usable
  • Switch GovernanceActionIx to Word32 fro Word64 and remove Num and Enum instances, which are dangerous due to potential overflows.
  • Deprecate transStakeCred, which is identical to transCred
  • Account for patch release of two packages: https://github.com/input-output-hk/cardano-haskell-packages/pull/418

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins force-pushed the lehins/conway-txinfo branch from 5d65382 to 4b94ce3 Compare August 1, 2023 11:48
@lehins lehins marked this pull request as ready for review August 1, 2023 11:49
@lehins lehins force-pushed the lehins/conway-txinfo branch from 4b94ce3 to b681010 Compare August 1, 2023 11:57
@lehins lehins requested a review from teodanciu August 1, 2023 11:57
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@lehins lehins merged commit 17587cf into master Aug 1, 2023
@iohk-bors iohk-bors bot deleted the lehins/conway-txinfo branch August 1, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants