Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out zero TxOuts on Byron/Shelley boundary instead of Babbage/Conway #3600

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Aug 2, 2023

Description

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@teodanciu
Copy link
Contributor

Just curious what motivated this change, something in particular?

@lehins
Copy link
Collaborator Author

lehins commented Aug 3, 2023

Just curious what motivated this change, something in particular?

Yeah, doing this filtering on Babbage/Conway boundary causes problems for UTXO-HD implementation, so I suggested we do it on Byron/Shelley boundary instead. This will not cause any problems, since those TxOuts are unspendable. Moreover it only affects testnets anyways.

Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@lehins lehins force-pushed the lehins/remove-zero-txouts-in-byron branch from 69188c6 to 71d1ee1 Compare August 3, 2023 14:05
@lehins lehins enabled auto-merge August 3, 2023 14:06
@lehins lehins merged commit d983cfb into master Aug 4, 2023
@iohk-bors iohk-bors bot deleted the lehins/remove-zero-txouts-in-byron branch August 4, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants