Adjust thresholds for sanchonet #3609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
changed the title
lehins
force-pushed
the
lehins/adjust-thresholds-for-sanchonet
branch
from
641ab5c
to
35e9d6a
Compare
teodanciu
reviewed
Aug 7, 2023
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Examples/ConwayFeatures.hs
Outdated
Show resolved
Hide resolved
Previous formula treaded `no` and `abstain` votes equivalently: `t = y / s` Current formula accounts for `abstain` votes: `t = y / (s - a)`, which is the same as: `t = (y / s) / (1 - a / s)`. Latter version is used for efficiency reasons. Temoprarely threashold is hard coded to 51% for StakePools for SanchoNet. This will be changed to the actual `ppPoolVotingThresholdsL` Protocol Parameter in the future. Fixup the test, to account for the threshold change.
These settings will change in the future, but they are desred right now for SanchoNet
lehins
force-pushed
the
lehins/adjust-thresholds-for-sanchonet
branch
from
35e9d6a
to
ea2245b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3605
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)