Add optional previous GovActionId in some ProposalProcedures #3615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/require-prev-govaction-id
branch
3 times, most recently
from
10b2a9b to
a02bd38
Compare
lehins
force-pushed
the
lehins/require-prev-govaction-id
branch
from
3053037 to
16763bc
Compare
lehins
force-pushed
the
lehins/require-prev-govaction-id
branch
from
16763bc to
0103a89
Compare
lehins
force-pushed
the
lehins/require-prev-govaction-id
branch
from
0103a89 to
19fecd6
Compare
* Wrap `PrevGovActionId` in `GovernanceActions` with a `StrictMaybe` in order to account fo rthe fact that we will start in the state in which there are no governance action * Addition of `GovActionPurpose` is motivated by the fact that we distinguish between previous governance action. Eg. `NoConfidence` and `NewCommittee` are considered to have the same purpose, while other are distinct.
lehins
force-pushed
the
lehins/require-prev-govaction-id
branch
from
19fecd6 to
ef62e9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3611
Implement
PrevGovActionIdandGovActionPurposePrevGovActionIdinGovernanceActionswith aStrictMaybeinorder to account fo rthe fact that we will start in the state in which
there are no governance action
GovActionPurposeis motivated by the fact that wedistinguish between previous governance action. Eg.
NoConfidenceandNewCommitteeare considered to have the same purpose, while otherare distinct. This will protect us from mixing them up when checking in
the governance state
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)