Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change constitution to use Anchor #3625

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Change constitution to use Anchor #3625

merged 1 commit into from
Aug 9, 2023

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Aug 9, 2023 •
edited by lehins
Loading

Description

This PR replaces the constitution has with Anchor. Replaced getConstitutionHash with getConstitution in EraGov. Added ConwayEraGov, which adds a lens for accessing the constitution.

closes #3613

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw force-pushed the jj/constitution-anchor branch 2 times, most recently from bdbbc90 to dfa363a Compare August 9, 2023 11:58
@Soupstraw Soupstraw requested a review from lehins August 9, 2023 11:58
@Soupstraw Soupstraw force-pushed the jj/constitution-anchor branch from dfa363a to 248b963 Compare August 9, 2023 12:02
@Soupstraw Soupstraw marked this pull request as ready for review August 9, 2023 12:04
@Soupstraw Soupstraw force-pushed the jj/constitution-anchor branch from 248b963 to e92103b Compare August 9, 2023 12:07
@Soupstraw Soupstraw requested review from aniketd and teodanciu August 9, 2023 12:08
@carbolymer carbolymer mentioned this pull request Aug 9, 2023
Merged
10 tasks
@Soupstraw Soupstraw force-pushed the jj/constitution-anchor branch 3 times, most recently from b51455c to 224c632 Compare August 9, 2023 16:32
@Soupstraw @lehins
Switched constitutionHash to constitutionAnchor
15e29fb 
* Also change `getConstituttionHash` function to `getConstitution`

* Add `queryConstitution`
@lehins lehins force-pushed the jj/constitution-anchor branch from 224c632 to 15e29fb Compare August 9, 2023 20:55
lehins
lehins approved these changes Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a few minor changes in order to get this PR over the line.

@lehins lehins enabled auto-merge August 9, 2023 21:05
@lehins lehins merged commit b5734a4 into master Aug 9, 2023
@iohk-bors iohk-bors bot deleted the jj/constitution-anchor branch August 9, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aniketd aniketd aniketd left review comments

@teodanciu teodanciu teodanciu left review comments

@lehins lehins lehins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch constitution hash to an Anchor
4 participants
@Soupstraw @aniketd @teodanciu @lehins